Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix multiplication operator change affects H dictionary creation #51

Closed
John-Tenet3 opened this issue Jul 2, 2024 · 1 comment · Fixed by #53
Closed

Matrix multiplication operator change affects H dictionary creation #51

John-Tenet3 opened this issue Jul 2, 2024 · 1 comment · Fixed by #53

Comments

@John-Tenet3
Copy link
Contributor

I'm not completely clear on when the switch over to the array interface in was made, but some years ago there was a change to scipy sparse matrix multiplication such that the * operator performs element-wise multiplication, breaking the code logic here somewhat invisibly. The matmul (@) operator was implemented way back in 0.17.0 so it might be worth switching to that operator to avoid getting caught out, if it's not already affected.

@John-Tenet3 John-Tenet3 changed the title Matrix multiplication notation change affects H dictionary creation Matrix multiplication operator change affects H dictionary creation Jul 2, 2024
@tbennun
Copy link
Collaborator

tbennun commented Jul 3, 2024

@John-Tenet3 That sounds right. Feel free to post a pull request that changes it.

John-Tenet3 added a commit to John-Tenet3/ncc that referenced this issue Jul 31, 2024
@tbennun tbennun linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants