Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetric vs Random Initialization for some benchmarks #28

Open
hardik01shah opened this issue Dec 14, 2024 · 0 comments
Open

Symmetric vs Random Initialization for some benchmarks #28

hardik01shah opened this issue Dec 14, 2024 · 0 comments

Comments

@hardik01shah
Copy link

For some benchmarks like correlation and covariance, the initialization of the matrix is a symmetric matrix. This unfortunately validates incorrect implementations for the benchmarks. Is there any specific reason for initializing the matrices as symmetric in the way they currently are?
On experimenting with random initialization, I found that they were less susceptible to validating wrong implementations for the benchmarks.

Happy to put in a PR addressing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant