Fix 'float_type' assertion error #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 94.52% 94.52%
=======================================
Files 16 16
Lines 1807 1807
=======================================
Hits 1708 1708
Misses 99 99
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@tbennun Could you take a look when you get the chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24, which is the assertion error encountered when transforming
float_type.Instead of using the
from_larkmethod to construct aFloatTypeinstance with unaltered args, this change uses a lambda function to call theFloatTypeconstructor with the value of the Token rather than the Token itself.