Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example files #256

Closed
meretp opened this issue Oct 28, 2022 · 2 comments
Closed

fix example files #256

meretp opened this issue Oct 28, 2022 · 2 comments
Labels
examples An issue with the provided examples (either for tests or as user guideline)

Comments

@meretp
Copy link
Collaborator

meretp commented Oct 28, 2022

The current example files aren't valid according to spec and need some fixes. Below is a list of comments from PR #254 where some of the issues were found.
@meretp meretp mentioned this issue Oct 28, 2022
Closed
@meretp
Copy link
Collaborator Author

meretp commented Oct 28, 2022

#254 (comment)
#254 (comment)

@meretp meretp mentioned this issue Oct 28, 2022
Merged
@nicoweidner nicoweidner added the examples An issue with the provided examples (either for tests or as user guideline) label Nov 4, 2022
@armintaenzertng
Copy link
Collaborator

Invalid example files have been removed in the refactored version now found on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
examples An issue with the provided examples (either for tests or as user guideline)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meretp @nicoweidner @armintaenzertng