-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Auth0 implementation #19
Comments
Hey there Thanks for the suggestion, it is actually on the cards to make this package integrated with Passport, and so I will add Auth0 to that as well 👍 |
@specialtactics thanks for the answer. I've integrated the Auth0 JWT management and I can now login using Auth0 (Facebook, Google or anything else) and use the TokenId to call API boilerplate's endpoints. I'm just worried about a little thing: can you confirm that I can completely get rid of the api.auth middleware ? Since my SPA wont use or make any crud request for the users table on my Laravel api. |
@roasted-toast I am not use, the underlying dingo package relies on api.auth, if you replace it, then whatever you replace it with has to provide an equivalent implementation of authentication, and work with helpers like auth() |
@specialtactics +1 for https://laravel.com/docs/master/passport |
A JWT Auth system is implemented within the boilerplate. |
@egdavid got it. Love to see support for Laravel passport. |
It will definitely come, do not worry guys 😄 Right now the main trouble for me is that there's a lot of work on the roadmap, and trying to priorotise the easy wins. Right now, the built-in JWT will suffice for 80% of use cases. Next, I want to write HMAC authentication, which will take some effort because I don't think there are any maintained laravel auth hmac implementations, but it's very useful for APIs. Down the track a bit will be passport and/or auth0. |
@specialtactics I could create a PR of my own implementation of Auth0 if you want. |
@egdavid If you've integrated it into the boilerplate, I would definitely love to see ! So long as it won't break any existing functionality and can be turned on/off, it should be fine. |
@specialtactics in this particular case it will require some changes, there is no way to turn it on or off for example and I'm not sure it would not break the existing JWT auth system since I "got rid" of it. |
No problem @egdavid , there's no rush for sure, as I myself wouldn't get to it for months. If you feel like contributing, it would be very welcome. Dingo itself has configurable auth providers, I think that's the place to start to make it swappable. |
@specialtactics I'm about to publish a PR with my own implementation of Auth0. You should probably create a Dev branch so I could publish it without affecting the main one? |
@egdavid Sure, I've pushed a "dev" branch, based off the latest master. Can't wait to see! |
@specialtactics I'm updating the code based on the latest master and my public (unauthenticated) routes don't work anymore.
Any idea? EDIT: seems like I've had some issues with my custom API Policies. I've removed them for the incoming push. |
So did you fix the issue @egdavid ? I would advise, if you have unauthenticated routes, the model used by those controllers can't have a policy, since there wouldn't be any logged in user to check any access policies against. |
Hey guys, +1 on this. Any updates? |
No updates sorry, not a priority unfortunately at the moment ! |
How compatible is this boiler plate if laravel changes in the future but
the boiler plat did not? Are the changes to laravel a lot? Or is it mostly
outside of changes to the laravel framework?
…On Thu, Apr 2, 2020 at 3:41 PM Max ***@***.***> wrote:
No updates sorry, not a priority unfortunately at the moment !
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOOX7PU2NWCJHRNT7APRXTRKUIBPANCNFSM4HSBLGWQ>
.
|
@mroushdy Nothing of laravel is changed actually, it all works through packages and inheritance. It's the same version of Laravel as any other. |
Hello Dear
Error in bootstrap script: Illuminate\Database\QueryException: |
@Master-maynd
If it all fails I suggest
|
Any thoughts on implementing the Laravel Auth0 package ?
Auth0 is regularly used by api consumers and it could be great making endpoints compatible with this authentication system.
The text was updated successfully, but these errors were encountered: