Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with uploading COGs through workbench #5418

Open
emenslin opened this issue Nov 26, 2024 · 0 comments
Open

Issues with uploading COGs through workbench #5418

emenslin opened this issue Nov 26, 2024 · 0 comments
Labels
1 - Bug Incorrect behavior of the product 2 - WorkBench Issues that are related to the WorkBench geospecify
Milestone

Comments

@emenslin
Copy link
Collaborator

Describe the bug
Overall uploading COGs in the workbench does not always seem to work as expected except for the basic cases with just cog name and type. I'm going to list a few things I ran into in this issue, some may be issues and some may be the correct behavior but might just need further explanation, either way I wanted to list them all out just in case.

  1. When adding COG children to a COG you can mark isPrimary and isSubstrate as true
  2. Along with that 'isPrimary' seems to be hidden in workbench but not anywhere else, if this is the expected behavior it should be explained
  3. Might be unrelated to wb but when a child cog has 'isPrimary checked you can't uncheck it
  4. Sometimes the COGtype doesn't get set properly and shows the api, this normally fixes itself but still shouldn't be shown to the user in the first place
  5. If a CO is already a child to a COG and you try to map it to a different COG the error message isn't very clear

To Reproduce
Steps to reproduce the behavior:

  1. Go to workbench
  2. Select COG as base table
  3. Map all required fields for COG
  4. Go through 'children' and map to CO and COG

Example mappings based on WB required fields: https://nbmmnb20240628-production.test.specifysystems.org/specify/workbench/plan/116/

Query of existing COGs: https://nbmmnb20240628-production.test.specifysystems.org/specify/query/47/

Expected behavior
Either these issues should be fixed or there should be an explanation for why the current behavior is correct

Screenshots

Setting child COG 'isSubstrate' to true:

chrome_Ftaiut5C5E.mp4

Can't uncheck 'isPrimary' and shows api:

chrome_QeVYfDuiJ1.mp4

I uploaded this data set and made no changes and then I couldn't roll it back, also shows the api:

chrome_ymBbrYBHml.mp4

Data set link: https://nbmmnb20240628-production.test.specifysystems.org/specify/workbench/114/

CO is a child of another COG but the error message shows under 'isSubstrate' instead of the cat # (which would make more sense to me)

Screenshot 2024-11-26 113838

Please fill out the following information manually:

Additional context
I probably missed some things so I encourage whoever works on this to check other cases in the UI to see if the behavior is correct or not.

@emenslin emenslin added 1 - Bug Incorrect behavior of the product 2 - WorkBench Issues that are related to the WorkBench labels Nov 26, 2024
@grantfitzsimmons grantfitzsimmons added this to the 7.9.11 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - WorkBench Issues that are related to the WorkBench geospecify
Projects
None yet
Development

No branches or pull requests

2 participants