Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Object children in a COG without a CatalogNumber do not display when expanded #5430

Open
grantfitzsimmons opened this issue Dec 3, 2024 · 0 comments
Labels
1 - Bug Incorrect behavior of the product geospecify

Comments

@grantfitzsimmons
Copy link
Member

Steps to Reproduce:

  1. Log into a discipline with the type geology (e.g. Geology on geo_2024_12_03)
  2. Add a CO to a COG without a catalog number
  3. Expand that
  4. See that it doesn't appear
  5. Add a CO to a COG with a catalog number
  6. See that it appears
Screen.Recording.2024-12-03.at.3.10.28.PM.mov

It may have to do with the view, but the conditions that would change how this is rendered do not include catalog number.

<viewdef name="CollectionObjectGroupJoin" class="edu.ku.brc.specify.datamodel.CollectionObjectGroupJoin" type="form" gettable="edu.ku.brc.af.ui.forms.DataGetterForObj" settable="edu.ku.brc.af.ui.forms.DataSetterForObj">
	<desc>The Collection Object Group Join Form</desc>
	<enableRules/>
	<columnDef>50px,2px,30px,5px,50px,2px,30px,5px,50px,2px,100px,0px,50px,2px,100px,p:g</columnDef>
	<rowDef auto="true" cell="p" sep="2px"/>
	<rows>
		<row>
			<cell type="panel" colspan="20">
				<rows>
					<row>
						<cell type="label" labelfor="1"/>
						<cell type="field" id="1" name="isPrimary" uitype="checkbox" default="false"/>
						<cell type="label" labelfor="2"/>
						<cell type="field" id="2" name="isSubstrate" uitype="checkbox" default="false"/>
						<cell type="label" labelfor="5"/>
						<cell type="field" id="5" name="childCo" uitype="querycbx" readonly="true" colspan="3"/>
					</row>
					<row>
						<!-- Collection Object Details -->
						<cell type="label" label="CO Type"/>
						<cell type="field" id="objectType" name="childCo.collectionObjectType.Name" uitype="text" readonly="true"/>
						<cell type="label" label="Name"/>
						<cell type="field" id="currentDet" name="childCo.currentDetermination.preferredTaxon.fullName" uitype="text" readonly="true"/>
						<cell type="label" label="Collecting Event"/>
						<cell type="field" id="collectingEvent" name="childCo.collectingEvent.stationFieldNumber" uitype="text" readonly="true"/>
						<cell type="label" label="Locality"/>
						<cell type="field" id="locality" name="childCo.collectingEvent.locality.localityName" uitype="text" readonly="true"/>
					</row>
				</rows>
				<rows condition="childCO=_EMPTY">
					<row/>
				</rows>
			</cell>
		</row>
		<row>
			<cell type="panel" colspan="20">
				<rows>
					<row>
						<cell type="label" labelfor="1"/>
						<cell type="field" id="1" name="isPrimary" uitype="checkbox" readonly="true" default="false"/>
						<cell type="label" labelfor="2"/>
						<cell type="field" id="2" name="isSubstrate" uitype="checkbox" readonly="true" default="false"/>
						<cell type="label" labelfor="6"/>
						<cell type="field" id="6" name="childCog" uitype="querycbx" readonly="true" colspan="3"/>
						<cell type="label" label="COG Type"/>
						<cell type="field" id="typeOfGroup" name="childCog.COGType.Name" uitype="text" readonly="true"/>
					</row>
				</rows>
				<rows condition="childCOG=_EMPTY">
					<row/>
				</rows>
			</cell>
		</row>
		<row>
			<cell type="panel" colspan="20">
				<rows>
					<row>
						<cell type="subview" viewname="CollectionObjectMini" id="childCO" name="childCo" uitype="subview" colspan="20"/>
					</row>
				</rows>
				<rows condition="childCo=_EMPTY">
					<row/>
					<!-- Show nothing if no Collection Object Group (COG) or Collection Object (CO) child exists for this COJO record -->
				</rows>
			</cell>
		</row>
		<row>
			<cell type="panel" colspan="15">
				<rows>
					<row>
						<cell type="subview" viewname="CollectionObjectGroup" id="childCog" name="childCog" colspan="20"/>
					</row>
				</rows>
				<rows condition="childcog=_EMPTY">
					<row/>
					<!-- Show nothing if no Collection Object Group (COG) or Collection Object (CO) child exists for this COJO record -->
				</rows>
			</cell>
		</row>
		<!-- 		<row>
			<cell type="label" labelfor="7"/>
			<cell type="field" id="7" name="version" uitype="text"/>
			<cell type="label" labelfor="8"/>
			<cell type="field" id="8" name="timestampCreated" uitype="text"/>
			<cell type="label" labelfor="9"/>
			<cell type="field" id="9" name="timestampModified" uitype="text"/>
		</row>
		<row>
			<cell type="label" labelfor="10"/>
			<cell type="field" id="10" name="text1" uitype="text"/>
			<cell type="label" labelfor="11"/>
			<cell type="field" id="11" name="text2" uitype="text"/>
			<cell type="label" labelfor="12"/>
			<cell type="field" id="12" name="text3" uitype="text"/>
		</row>
		<row>
			<cell type="label" labelfor="13"/>
			<cell type="field" id="13" name="integer1" uitype="text"/>
			<cell type="label" labelfor="14"/>
			<cell type="field" id="14" name="integer2" uitype="text"/>
			<cell type="label" labelfor="15"/>
			<cell type="field" id="15" name="integer3" uitype="text"/>
		</row>
		<row>
			<cell type="label" labelfor="16"/>
			<cell type="field" id="16" name="Yesno1" uitype="checkbox"/>
			<cell type="label" labelfor="17"/>
			<cell type="field" id="17" name="Yesno2" uitype="checkbox"/>
			<cell type="label" labelfor="18"/>
			<cell type="field" id="18" name="Yesno3" uitype="checkbox"/>
		</row> -->
	</rows>
</viewdef>

Full form definition:
CommonCOGIssue.xml.zip

production at fa3bb5c, macOS, Arc

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product geospecify labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product geospecify
Projects
None yet
Development

No branches or pull requests

1 participant