Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names for test classes are inconsistent #1005

Open
nickssl opened this issue Sep 4, 2024 · 1 comment
Open

Names for test classes are inconsistent #1005

nickssl opened this issue Sep 4, 2024 · 1 comment
Labels
enhancement New feature or request refactoring

Comments

@nickssl
Copy link
Contributor

nickssl commented Sep 4, 2024

This is a minor issue which is easy to fix.

VSCode has a separate section for tests and it lists all the tests in the project (see attached image). This is very useful for debugging. This feature would be easier to use if the names for the Class objects in the various tests.py files follow a consistent naming scheme. One possibility is to name all the classes "LoadTestCases" since the majority of the existing tests already use this name. Another possibility is to use "folder-name_tests", for example Kompsat_Tests, Fast_Tests, and so on. This is an easy change to make, and as far as I know, it does not affect anything else.

tests

@nickssl nickssl added enhancement New feature or request refactoring labels Sep 4, 2024
@jameswilburlewis
Copy link
Contributor

Yes, it would probably be good to make these more descriptive. I know I'm frequently guilty of just cloning a test.py file and replacing the test methods....at the very least, the class names should include the project name or category the tests are meant to be exercising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

No branches or pull requests

2 participants