Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer truncates PATH? #582

Open
activivan opened this issue May 31, 2024 · 3 comments
Open

Windows installer truncates PATH? #582

activivan opened this issue May 31, 2024 · 3 comments

Comments

@activivan
Copy link

activivan commented May 31, 2024

Windows installer (https://download.speedata.de/dl/speedata-publisher-windows-amd64-4.18.0-installer.exe) does not just add speedata to the user environment path variable, it overwrites it and deletes existing entries!

Edit (PG): This might be due to an overlong PATH variable which gets truncated during installation. Check!

@pgundlach
Copy link
Member

Hello activian,

thank you very much for your bug report! I am afraid I cannot reproduce the problem. I have set a user PATH in the settings menu to "C:\Users\Patrick\Desktop\pg"

After installing the speedata Publisher with the file you link to, another Path entry has been added:

path

Is this not what you see?

Can you post a more detailed description of the problem? I am not a windows user, so I am very thankful for any help here.

@activivan
Copy link
Author

Hey, I tried to recreate my problem, but this time it worked fine. If I recall, my original PATH variable was pretty long/full. After doing some research, I found out that NSIS (installer) can have difficulties with too long PATH variables (https://nsis.sourceforge.io/Path_Manipulation#Warning), though I don't know if this applies to the speedata Publisher.
After installing speedata, I noticed that my PATH variable has been replaced, so I concluded that it was speedatas fault - of course I don't know for sure and maybe I'm wrong. Beste Grüße!

@pgundlach pgundlach changed the title Windows installer overwrites PATH [!!!] Windows installer truncates PATH? Jun 1, 2024
@pgundlach
Copy link
Member

I think this is still an issue (truncating PATH variable), I will try to find a way to warn the user if this happens. Still thank you very much for brining this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants