Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubling concepts or entities #6

Open
bartbink opened this issue Aug 23, 2024 · 2 comments
Open

Doubling concepts or entities #6

bartbink opened this issue Aug 23, 2024 · 2 comments

Comments

@bartbink
Copy link

https://github.com/spherity/oid-public/blob/main/docs/contexts/eucc/vocabulary.md#4-information-model

I see that some entities/classes/attributes are stated more than once using an other name. An example is found in the information model of the EUCC. For the class NaturalPerson the attribute domicile links to the class Domicile. For the class LegalPerson the attibute registeredAddress is a string.

If we adhere to the EU vocabularies I propose the following:

  • For the class NaturalPerson the attribute domicile links to the class Address
  • For the class LegalPerson the attibute registeredAddresslinks to the class Address
@rkxx
Copy link
Contributor

rkxx commented Aug 23, 2024

string for registeredAddress is just a copyAndPaste-Failure. I will correct this. It should reuse registeredAddress from business core vocabulary as shown in the example of the Legal Person Credential .

For a natural person there are 2 attributes related to the location.

postalAddress: The full postal address. I would prefer to reuse the common terms defined by schema.org - https://schema.org/PostalAddress - because these terms are much more descriptive. But we can also use Address from the EU Core location vocabulary - https://www.w3.org/ns/legacy_locn#Address.

domicile: This is not the Address of the natural person. It just holds postal code, location (city) and country. Therefore, we have decided to model Domicile as a separate class. But again we can use the class Address for an expected value of domicile, it is just somewhat misleading.

@PerNordanlind
Copy link

I think it is good to use class Address, you can just ad an association called domicile next to registeredAddress. In NSG&B we added association postalAddress, some nordic countries have a registered address and a postal address at the company registration offices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants