Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lyrics-Plus] Add PetitLyrics as a lyrics provider in lyrics-plus #3253

Closed
Fortress937 opened this issue Dec 24, 2024 · 4 comments
Closed

[Lyrics-Plus] Add PetitLyrics as a lyrics provider in lyrics-plus #3253

Fortress937 opened this issue Dec 24, 2024 · 4 comments

Comments

@Fortress937
Copy link

📝 Provide a description of the new feature

I feel that lyrics-plus is a great custom apps to fetch lyrics from different sources (Musixmatch, Netease etc...), well maybe it will be good idea to add more lyrics provider? (Or probably bad). I've found that PetitLyrics can be a great one to be added to lyrics-plus as a provider.

About PetitLyrics
Petitlyrics is a service where many users can post synchronized lyrics that can be either (Plain Text = Unsynced), (Line Sync = Synced), or (Word Sync = Karaoke), most of them usually post word synced lyrics, which is karaoke lyrics, i heard that it can be used as a provider that fetch lyrics from them. Petitlyrics

Something about API
some people also requested to add petitlyrics as a provider, but is in different repository

It's nice to be added, but your choices.

➕ Additional Information

  • Applied to Lyrics-Plus
@rxri
Copy link
Member

rxri commented Dec 24, 2024

Aren’t these taken from netease really. Not needed I think

@rxri rxri closed this as not planned Won't fix, can't repro, duplicate, stale Dec 24, 2024
@Fortress937
Copy link
Author

Aren’t these taken from netease really. Not needed I think

I don't think it was taken from netease, maybe they look familiar, if i'm not wrong, maybe try check it a bit since Netease and PetitLyrics wasn't a same thing, and i guess PetitLyrics was Japanese lyrics provider while Netease was Chinese lyrics provider??

@Fortress937
Copy link
Author

Fortress937 commented Dec 24, 2024

Unless netease and petitlyrics uses the same API or functions, then i'm wrong, if you're aren't sure, explore it yourself.

@Fortress937
Copy link
Author

Fortress937 commented Dec 24, 2024

Plus, Netease are open-source, while Petitlyrics are closed-source, there are a repository for Netease, but for Petitlyrics, there isn't a way to check the source code from them (Unless you find it from EeveeSpotify repository, as they managed to get Petitlyrics API.) I guess Petitlyrics is made by SyncPower Corporation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants