Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the compressor and layout strategy #2173

Open
Tracked by #2116
gatesn opened this issue Jan 31, 2025 · 1 comment
Open
Tracked by #2116

Update the compressor and layout strategy #2173

gatesn opened this issue Jan 31, 2025 · 1 comment

Comments

@gatesn
Copy link
Contributor

gatesn commented Jan 31, 2025

Compression should be split into chunk compression and layout compression.

Chunk Compression

The chunk compressor operates over a single chunk of (canonical?) data. It may use external state from previous chunks to prune the search space for compression strategies. Currently it has a naive stats-based search space, there are ways to improve and speed this up.

Layout Compression

Layout compression occurs in LayoutWriter and is configured as part of a layout strategy. ChunkedLayoutWriter should buffer and repartition data into reasonable chunks, and then provide compressor state across chunks to assist with compression.

DictLayoutWriter should attempt to accumuluate a dictionary of values, if this values, fallback to writing regular chunked array.

We may even want to re-use compression state across columns if the dtype is the same and the stats are similar, e.g. for 100k columns of model weights.

The VortexLayoutStrategy should also be configurable per FieldPath if the user wishes to override these things.

@gatesn gatesn mentioned this issue Jan 31, 2025
23 tasks
@robert3005
Copy link
Member

I would add additional point that it should be possible to obtain same compressed states for in memory arrays and on disk arrays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants