Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging upstream #13

Open
nbransby opened this issue Jan 13, 2021 · 5 comments
Open

Merging upstream #13

nbransby opened this issue Jan 13, 2021 · 5 comments

Comments

@nbransby
Copy link

HI guys, hope you are all well!

I've noticed you have one of the most active forks of the firebase-kotlin-sdk and wanted to see what I can do to ensure the rest of the community don't miss out on all the extra functionality you have added here.

Any chance you could give me an overview of the features you have added and if there any blockers preventing you from merging those upstream?

@thoutbeckers
Copy link

Mostly time constraints since we had to ship something. We expect to have time for this soon.

I know it's not ideal but would it be ok to do this as one big PR?

Improvements are mostly for firestore and auth, and we're also adding support for remote-config (entirely new module). If we make a PR we will make a more granular list.

@thoutbeckers
Copy link

We also intend to keep making improvements as we need them in the future. Perhaps we can discuss some time how to better keep in sync after we merge everything.

@nbransby
Copy link
Author

Is there a way you can avoid one big PR? I suspect it's going to be too much to review in one go

@Daeda88
Copy link
Collaborator

Daeda88 commented Feb 9, 2021

Hi @nbransby I'm going to try and catalogue what we have and see if I can somehow split it up into smaller chunks.

@nbransby
Copy link
Author

nbransby commented Feb 9, 2021

Hi @Daeda88 we have actually split it by module ( starting with app & common) and review these separately:
GitLiveApp#146
GitLiveApp#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants