Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI extension author(s) names coloring breaks across lines #4384

Open
dregad opened this issue Dec 22, 2024 · 2 comments · May be fixed by splitbrain/php-cli#36
Open

CLI extension author(s) names coloring breaks across lines #4384

dregad opened this issue Dec 22, 2024 · 2 comments · May be fixed by splitbrain/php-cli#36
Labels
Bug

Comments

@dregad
Copy link
Contributor

dregad commented Dec 22, 2024

The problem

When listing extensions via CLI, the author's name is colored in purple, but the color is lost when the text is continued on the next line, as shown in the screenshot:

image

It works fine (i.e. the text is fully colored) when the author's name is on a single line (green rectangles), but if there is a line break then the color is reset to white (red rectangles).

Version of DokuWiki

master (fc09308)

PHP Version

8.2.26

Webserver and version of webserver

No response

Browser and version of browser, operating system running browser

No response

Additional environment information

No response

Relevant logs and/or error messages

No response
@dregad dregad added the Bug label Dec 22, 2024
@dregad
Copy link
Contributor Author

dregad commented Dec 22, 2024 •
edited
Loading

In my opinion, this coloring of the author has no added value.
Moreover, it puts emphasis on the author, when the more interesting information is the extension's description.

I suggest to remove it.

@dregad dregad linked a pull request Dec 23, 2024 that will close this issue
Open
@dregad
Copy link
Contributor Author

dregad commented Dec 23, 2024

Regardless of me thinking that color is not necessary here, I submitted splitbrain/php-cli#36 to fix the bug in php-cli.

If you agree with me that all these colors are superfluous, I'll gladly provide a PR to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color not continued on next line when wrapping text dregad/php-cli
1 participant
@dregad