-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for checkboxgroup component #439
Merged
harshilgajera-crest
merged 8 commits into
main
from
feat/adding-checkbox-group-component
Sep 19, 2024
Merged
feat: adding support for checkboxgroup component #439
harshilgajera-crest
merged 8 commits into
main
from
feat/adding-checkbox-group-component
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilgajera-crest
requested review from
mkolasinski-splunk and
kdoroszko-splunk
September 13, 2024 10:36
pytest_splunk_addon_ui_smartx/components/controls/checkboxgroup.py
Outdated
Show resolved
Hide resolved
pytest_splunk_addon_ui_smartx/components/controls/checkboxgroup.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider covering all new functionalities with test scenarios.
pytest_splunk_addon_ui_smartx/components/controls/checkboxgroup.py
Outdated
Show resolved
Hide resolved
mkolasinski-splunk
approved these changes
Sep 18, 2024
harshilgajera-crest
deleted the
feat/adding-checkbox-group-component
branch
September 19, 2024 05:31
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for testing checkbox-group component.