Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Notice: placeholder usage is going to be deprecated #831

Closed
artemrys opened this issue Sep 14, 2023 · 3 comments
Closed

Deprecation Notice: placeholder usage is going to be deprecated #831

artemrys opened this issue Sep 14, 2023 · 3 comments
Labels
deprecation Deprecation notice

Comments

@artemrys
Copy link
Member

artemrys commented Sep 14, 2023

UCC uses Splunk UI to render the UI part of the add-on. Splunk UI decided to deprecate placeholder prop for some of the components. In UCC we are doing the same. It is recommended to use help instead.

  • As of UCC v5.28.6 placeholder is still usable.
  • Future releases are still going to support it in the globalConfig file, but do not render it in the UI.
  • Future future releases are not going to support it in globalConfig file and users are going to see the error during the schema validation.
@vtsvetkov-splunk
Copy link
Contributor

It was actually removed from UI in 5.29.0 (2023-09-22) which is breaking change - it broke UI tests. Should we adjust schema.json to disallow having the field?

affected: https://github.com/splunk/splunk-add-on-for-microsoft-365-defender/pull/366/

@artemrys
Copy link
Member Author

It was actually removed from UI in 5.29.0 (2023-09-22) which is breaking change - it broke UI tests. Should we adjust schema.json to disallow having the field?

Yes, let's do this.

@hetangmodi-crest
Copy link
Contributor

The placeholder component has been removed as a part of v5.48.0 (#1256) release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecation notice
Projects
None yet
Development

No branches or pull requests

3 participants