Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-3798: add new filters for new test filters #19

Conversation

bchhay-splunk
Copy link
Collaborator

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output


Does this introduce a breaking change?

  • Yes
  • No

@greatestusername-splunk
Copy link
Collaborator

@bchhay-splunk mind taking a look at the lint failures in CI Checks? Looks mostly like some type checking that needs a quick clean up.

Thanks!

@bchhay-splunk
Copy link
Collaborator Author

@greatestusername-splunk this is ready for review again. Thanks!

Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small test update other than that lgtm!

syntheticsclientv2/get_checksv2.go Show resolved Hide resolved
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greatestusername-splunk greatestusername-splunk merged commit ef1b21b into splunk:v2 Apr 16, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants