splunk_indexes type fixes #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahkemp-splunk
requested review from
guohuang,
dfederschmidt,
clarafeb1,
dtwersky,
anelson-splunk,
rfrey-splunk and
leij-splunk
guohuang
approved these changes
Apr 26, 2022
anushjay
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
splunk_indexesresource to use the proper types, as defined by what is returned by the Splunk REST API.While the REST documentation states that
bucketRebuildMemoryHintandrepFactorcan be set by string value, they are always returned by the REST API as integers.Additionally,
repFactoris returned as0when the index is configured for bothrepFactor = 0andrepFactor = auto, making it impossible to differentiate between the two configured values. Because of this failure, and because that setting is only really valid on clustered indexes which should be configured by the Indexer Cluster Manager anyway, I've deprecatedrepFactor.These failures went unnoticed because JSON unmarshaling errors were ignored. The first commit in this PR handles errors returned when unmarshaling Index data, which otherwise triggers failing tests.
The CHANGELOG update bumps the version of the provider by a minor version, because there are some (minor) breaking changes.