Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating doesn't work in new version deadbeef #12

Open
maxorbase opened this issue Mar 29, 2021 · 4 comments
Open

Rating doesn't work in new version deadbeef #12

maxorbase opened this issue Mar 29, 2021 · 4 comments

Comments

@maxorbase
Copy link

A plugin doesn't work in new version of deadbeef
after rating a song deadbeef closed and create empty temp file in song directory like this
Avalon - Ane Marie.mp3.temp
tested in kubuntu 20.10 , deadbeef Nightly builds and Stable builds 1.8.7 and 1.8.6

@ghost
Copy link

ghost commented Aug 19, 2021

Also doesn't work for me on EndevourOS git version 1.8.8.
Abandonware.

@NamcoPro
Copy link

Not working on my end as well.
Rating the track with its column is fine until after you re-open deadbeef.
I see the files modified and everything on the file manager, but the rating is not saved.

deadbeef 1.9.1 on Manjaro.

@istepaniuk
Copy link

istepaniuk commented Dec 5, 2022

With the current devel/static/portable version, ratings are not -always- saved either. not reflected on the playlist after restoring the session (the tags are being written correctly to the files).

Workaround: After setting a rating, closing and resuming the session, doing a "Reload metadata" on the tracks that changed seems to write reflect the new tag correctly.

EDIT: clarified that, at least in my case, this is related to the playlist metadata, not the idv3 tags in my files (which are correctly written).

@istepaniuk
Copy link

istepaniuk commented Dec 29, 2022

I suspect this is a bug in DeaDBeeF, not in this plugin. I reported this: DeaDBeeF-Player/deadbeef#2909

EDIT: NOPE!, this is a bug here. I have not checked but it seems to have been fixed in the (open) PR #6 by @kpcee. The code in master lacks the calls to deadbeef->plt_modified (...); as required by the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants