Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saveAs function donnot catch file read failed error #8

Open
hill-mickey opened this issue Aug 15, 2014 · 0 comments
Open

saveAs function donnot catch file read failed error #8

hill-mickey opened this issue Aug 15, 2014 · 0 comments

Comments

@hill-mickey
Copy link

Problem:
saveAs function throws file read failed error
Reason:
toBuffer function use 'fs' module sync function to read file, but donnot try/catch the error or other error handler.
Although there is a callback(error) function in arguments, but still need developer to try/catch the saveAs function.

I think it's maybe a bug.

@hill-mickey hill-mickey changed the title saveAs function donot catch file read error saveAs function donnot catch file read failed error Aug 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant