Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "Only valid bearer authentication supported, reason: None" #832

Closed
wants to merge 1 commit into from

Conversation

stephanebruckert
Copy link
Member

@stephanebruckert stephanebruckert commented Jun 19, 2022

Fixes #687, #828


To keep backward-incompatibility we shouldn't have made as_dict=True the default in get_access_token methods. This PR swaps it back to False. Therefore this must be seen as a bugfix rather than a new backward-incompatible change.

Normally, this shouldn't have too much effect on new code as we now don't recommend to get the token independently via get_access_token() in order to authenticate (see README).

If you have been using get_access_token() in new code, you should now use get_access_token(as_dict=True).

@stephanebruckert stephanebruckert linked an issue Jun 19, 2022 that may be closed by this pull request
@stephanebruckert stephanebruckert changed the title Fixes Only valid bearer authentication supported, reason: None Fixes "Only valid bearer authentication supported, reason: None" Jun 19, 2022
@stephanebruckert
Copy link
Member Author

Actually I'm going to close this, I think I got it wrong. From this PR https://github.com/plamere/spotipy/pull/435/files it looks like we were always returning a dict.

@stephanebruckert stephanebruckert deleted the fix-token-as-dict branch June 19, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in minor version? Error Only valid bearer authentication supported, reason: None??
1 participant