You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 29, 2019. It is now read-only.
There's something that worries me about this extension: It adds lots of unscoped, private methods to the CheckoutController (all_opts, order_opts etc.). This could lead to big trouble if other extensions add methods with the same names to the CheckoutController.
I see two possible solutions:
The proper way would probably be to extract one or multiple actual objects that handle the PayPal behavior and are used in the controller.
The other – and potentially easer – solution would be to just prefix all methods with paypal_ or paypal_express (like the public methods are).
I could provide a pull request for either solution if need be. The second option could be done quickly but I'd need time to implement the first.
Let me know what you think.
Cheers.
The text was updated successfully, but these errors were encountered:
There's something that worries me about this extension: It adds lots of unscoped, private methods to the CheckoutController (
all_opts
,order_opts
etc.). This could lead to big trouble if other extensions add methods with the same names to the CheckoutController.I see two possible solutions:
paypal_
orpaypal_express
(like the public methods are).I could provide a pull request for either solution if need be. The second option could be done quickly but I'd need time to implement the first.
Let me know what you think.
Cheers.
The text was updated successfully, but these errors were encountered: