Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the hardcoded versions in the CI pipeline #162

Open
onobc opened this issue Jan 22, 2022 · 0 comments
Open

Get rid of the hardcoded versions in the CI pipeline #162

onobc opened this issue Jan 22, 2022 · 0 comments

Comments

@onobc
Copy link
Collaborator

onobc commented Jan 22, 2022

This is improvement ticket.

In ci.yml we have to list the docker images to push to Docker registry. The image includes a hardcoded version number.

It would be an improvement to not require this version number that is controlled via the pom.xml. This introduces toil when the version number needs to be changed.

It would be even nicer if the list of docker-images did not need to be provided and instead one of the GH actions output the proper list of image names to push.

  user-clicks-per-region-12x:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: ./.github/actions/build-sample-app
        with:
          app-dir: 'multi-io-samples/kafka-streams/user-clicks-per-region-1.2.x'
          mvn-build-commands: '-B clean install spring-boot:build-image -pl http-click-ingest,http-region-ingest,http-clicks-and-region-ingest,user-clicks-per-region-processor,log-user-clicks-per-region'
          ....
          docker-images: >-
            springcloudstream/multi-io-sample-http-click-ingest:2.0.0-SNAPSHOT
            springcloudstream/multi-io-sample-http-region-ingest:2.0.0-SNAPSHOT
            springcloudstream/multi-io-sample-http-clicks-and-region-ingest:2.0.0-SNAPSHOT
            springcloudstream/multi-io-sample-user-clicks-per-region-processor:2.0.0-SNAPSHOT
            springcloudstream/multi-io-sample-log-user-clicks-per-region:2.0.0-SNAPSHOT
@onobc onobc changed the title ITEM 5: Fix the hardcoded versions in the GH actions build Fix the hardcoded versions in the GH actions build Jan 23, 2022
@onobc onobc changed the title Fix the hardcoded versions in the GH actions build Get rid of the hardcoded versions in the GH actions build Jan 23, 2022
@onobc onobc changed the title Get rid of the hardcoded versions in the GH actions build Get rid of the hardcoded versions in the CI pipeline Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant