Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Possibility to use terminationGracePeriodSeconds for Pods / Jobs for kubernetes #495

Open
klopfdreh opened this issue Nov 15, 2024 · 2 comments
Labels
status/need-triage Team needs to triage and take a first look type/enhancement Is an enhancement request
Milestone

Comments

@klopfdreh
Copy link

We faced some issues that the Composed Task Runner of Spring Cloud Data Flow Server received a SIGTERM and was shutdown gracefully inbetween DSL operations. The CTR then returned a non-error return code (0).

It would be great to set the terminationGracePeriodSeconds to a very low value (e.g. 1. - default is 30) so that the container is killed directly. In those cases we can detect the crash and use our restart mechanism.

See:

this could be configured for SCDF here like described here:

https://docs.spring.io/spring-cloud-dataflow/docs/current/reference/htmlsingle/#configuration-kubernetes-deployer

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Nov 15, 2024
@cppwfs cppwfs added this to the 3.0.x milestone Nov 15, 2024
@cppwfs cppwfs added the type/enhancement Is an enhancement request label Nov 15, 2024
@corneil
Copy link
Contributor

corneil commented Nov 19, 2024

Are you launching with createJob true or false?

@klopfdreh
Copy link
Author

Yes we are using createJob true - but from what I saw in the docs of Kubernetes it applies to Pods and Pods created by Jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need-triage Team needs to triage and take a first look type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants