Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Extract OpenRewrite parser #844

Open
8 of 25 tasks
fabapp2 opened this issue Jul 20, 2023 · 2 comments · Fixed by #832
Open
8 of 25 tasks

Epic: Extract OpenRewrite parser #844

fabapp2 opened this issue Jul 20, 2023 · 2 comments · Fixed by #832
Assignees
Labels
epic in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Jul 20, 2023

What needs to be done

The parsing logic to create the OpenRewrite AST from given resources should be extracted.
The currently used MavenProjectParser should then be replaced by this component.

Why it needs to be done

Parsing a given project to OpenRewrite AST is a mandatory step to apply OpenRewrite recipes.
Currently, two open-sourced build tool plugins exist that allow applying recipes inside a build.
Providing a parser that creates the AST outside of a build tool plugin is required for other projects too.
Extracting the parser allows reusing this component in these projects.

Acceptance Criteria

/info panel
Given precondition
When action
Then result

Additional Information

@fabapp2 fabapp2 added the epic label Jul 20, 2023
@fabapp2 fabapp2 linked a pull request Jul 20, 2023 that will close this issue
@fabapp2 fabapp2 reopened this Aug 2, 2023
@shresthaujjwal
Copy link

@fabapp2 any idea when the support for custom maven settings.xml support would be added ? Adhere to ~/.m2/settings-security.xml and ~/.m2/settings.xml

@fabapp2
Copy link
Contributor Author

fabapp2 commented Aug 9, 2023

Hi @shresthaujjwal

it should be working with the current parser used in isolation when using RewriteMavenProjectParser which replicates works as with the rewrite-maven-plugin.
It needs to be incorporated into the RewriteProjectParser and can be taken fron here. I will find or create an issue for this.

@fabapp2 fabapp2 added revamp in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic in: sbm-support-rewrite Issue is related to the sbm-support-rewrite compionent revamp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants