Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenRewriteMavenBuildFileTest.getEffectiveDependencies() in GH action #901

Open
fabapp2 opened this issue Aug 31, 2023 · 0 comments
Open
Labels
CI in: sbm-core type: bug Something isn't working

Comments

@fabapp2
Copy link
Contributor

fabapp2 commented Aug 31, 2023

          With 3a5a26b the `OpenRewriteMavenBuildFileTest.getEffectiveDependencies()` faiuls in GH action but "works in my machine". Currently out of scope, fix later. Disabling the test for now.
Error:  Tests run: 46, Failures: 1, Errors: 0, Skipped: 3, Time elapsed: 31.799 s <<< FAILURE! - in org.springframework.sbm.project.buildfile.OpenRewriteMavenBuildFileTest
Error:  getEffectiveDependencies  Time elapsed: 0.017 s  <<< FAILURE!
java.lang.AssertionError: 
Expected size: 3 but was: 2 in:
[<dependency>
   <groupId>javax.annotation</groupId>
   <artifactId>javax.annotation-api</artifactId>
   <version>1.3.2</version>
   <type>jar</type>
   <scope>test</scope>
</dependency>,
    <dependency>
   <groupId>com.example</groupId>
   <artifactId>module2</artifactId>
   <version>1.0</version>
   <type>jar</type>
   <scope>compile</scope>
</dependency>]

The problem seems to be that in GH build the transitive dependency of module2 is not retrieved.

Originally posted by @fabapp2 in #900 (comment)

@fabapp2 fabapp2 added type: bug Something isn't working CI labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI in: sbm-core type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant