Updated IgnoredPatterns & Added support for more Rewrite recipes #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shresthaujjwal
commented
Oct 19, 2023
shresthaujjwal
commented
- Updated IgnoredPatterns
- Added support for more Rewrite recipes
Added support for more Rewrite recipes
fabapp2
suggested changes
Oct 30, 2023
sbm-support-rewrite/src/main/java/org/springframework/sbm/parsers/ParserProperties.java
Outdated
Show resolved
Hide resolved
|
@fabapp2 sure. Got busy last few days. Let me see where I left off |
…-support-rewrite.properties
|
@fabapp2 can we get this merged |
fabapp2
suggested changes
Nov 14, 2023
sbm-support-rewrite/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.openrewrite.recipe</groupId> | ||
| <artifactId>rewrite-migrate-java</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Could you remove the "recipe" jars again?
They should not be part of the parser component by default.
There was a problem hiding this comment.
Sure @fabapp2. The reason the add them was so that we don't need to manage it it in core or the app where the sdk is being used ?
There was a problem hiding this comment.
Do u want me to remove the recipe bom too ?
|
@fabapp2 please review the change as requested, i have removed the recipe |
fabapp2
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.