Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NOT_IN, NOT_LIKE and NEGATING_SIMPLE_PROPERTY #604

Closed
wants to merge 1 commit into from
Closed

Add support for NOT_IN, NOT_LIKE and NEGATING_SIMPLE_PROPERTY #604

wants to merge 1 commit into from

Conversation

TomVanWemmel
Copy link
Contributor

Closes #603

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@pivotal-cla
Copy link

@TomVanWemmel Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2024
@pivotal-cla
Copy link

@TomVanWemmel Thank you for signing the Contributor License Agreement!

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 12, 2024
@mp911de mp911de self-assigned this Dec 16, 2024
@mp911de mp911de added this to the 3.5 M1 (2025.0.0) milestone Dec 16, 2024
mp911de pushed a commit that referenced this pull request Dec 16, 2024
@TomVanWemmel @mp911de
Add query derivation support for NOT_IN, NOT_LIKE and `NEGATING_S…
768d0a8 
…IMPLE_PROPERTY` predicates.

Closes #603
Original pull request: #604
mp911de added a commit that referenced this pull request Dec 16, 2024
@mp911de
Polishing.
8d97fdd 
Use switch expressions, extract variables where possible. Simplify comparisons and combine common predicate blocks. Use simpler types where possible.

See #603
Original pull request: #604
@mp911de
Copy link
Member

mp911de commented Dec 16, 2024

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5 M1 (2025.0.0)
Development

Successfully merging this pull request may close these issues.

Support for additional Part Types
4 participants
@TomVanWemmel @pivotal-cla @mp911de @spring-projects-issues