Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/2953 #2962

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

issue/2953 #2962

wants to merge 4 commits into from

Conversation

mkoertgen
Copy link

fixes #2953

@meistermeier
Copy link
Collaborator

Thanks a lot. I hope to have a look later this week (🤞 )

@meistermeier meistermeier self-assigned this Oct 28, 2024
@meistermeier meistermeier removed the status: waiting-for-triage An issue we've not yet triaged label Oct 30, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 30, 2024
@meistermeier
Copy link
Collaborator

Thanks again for this PR. I think it makes sense in this way, even though I am not completely happy with the syntax of readOnlyTxManager....(...., readOnly=true). It feels somehow like a duplication. On the other hand I see no way how the write-mode transaction manager in the executable query should know that it is about to join an ongoing transaction.

Something that is missing in the PR is the support for the reactive template manager (you're missing all the fun ;) )
Unfortunately there is no validate method on the reactive transaction manager that will help us (you) to verify that this is working, or I cannot find it right now.

@mkoertgen
Copy link
Author

Hi @meistermeier ,

Will add the reactive part. Thanks for reviewing 👍

@mkoertgen
Copy link
Author

Hi @meistermeier ,

As of now, AbstractReactiveTransactionManager does not support transactional validation as does AbstractPlatformTransactionManager.setValidateExistingTransaction.

So it does not make sense to add it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neo4jTemplate.DefaultExecutableQuery.getSingleResult() always executes in non-readonly transaction
3 participants