New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required peer dependencies are not installed #16

Open

josebolos opened this issue Mar 7, 2018 · 0 comments

Contributor

josebolos commented Mar 7, 2018 •

edited

Loading

After upgrading shunter from @springernature/[email protected] to @springernature/[email protected], running npm install returns the following:

npm WARN @springernature/[email protected] requires a peer of eslint-plugin-jest@^21.13.0 but none is installed. You must install peer dependencies yourself.

Relevant bits of the .eslintrc file:

"extends": [
	"@springernature/eslint-config",
	"@springernature/eslint-config/node"
],

I didn't add eslint-plugin-jest to shunter's devDependencies as I didn't realise it's necessary.

We need to:

assess the potential impact of having / not having that peer dependency included, and
change the docs to clarify if the dependency is needed in any case, and why.

The text was updated successfully, but these errors were encountered:

josebolos changed the title ~~Required peer dependencies is not installed~~ Required peer dependencies are not installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment