Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporating author's latest updates #5

Open
mcg1969 opened this issue May 7, 2017 · 1 comment
Open

Incorporating author's latest updates #5

mcg1969 opened this issue May 7, 2017 · 1 comment

Comments

@mcg1969
Copy link
Contributor

mcg1969 commented May 7, 2017

It looks like there have been two revisions or so since this GitHub repo was created. From the original site:

2017/05/06: fixed mex-functions incompatibility with Matlab 2016a
2016/10/26: fixed mex-functions incompatibility with Matlab 2015b

It would be good to incorporate those changes here, and indeed to encourage the authors to adopt the GitHub repo as canonical. Perhaps the latter is not likely but we can hope! (I have great respect for the authors bit Git can indeed be daunting for anyone new to it.)

But back to the first bit: incorporating the changes. It should be noted that we've made quite a few small but important changes that make a merge less simple. Most of them, I must admit, were stylistic, and primarily in response to the output of MATLAB's built-in linter. But some, like the use of || and && instead of | and &, are in my view more important, especially with regards to maintaining Octave compatibility. And there are some decidedly non-stylistic changes that we would seek to preserve as well.

Your mission, if you choose to accept it, is to download the latest version of SDPT3 and to gingerly merge any functional changes from that version into this repo.

@mcg1969
Copy link
Contributor Author

mcg1969 commented May 7, 2017

Here's a start: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant