Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move private code to private subdirectory #14

Open
shabbychef opened this issue Dec 23, 2014 · 5 comments
Open

move private code to private subdirectory #14

shabbychef opened this issue Dec 23, 2014 · 5 comments

Comments

@shabbychef
Copy link

Arguably none of the code here other than sedumi.m is needed by the end user. However, having a file with an innocuous name like ddot.m or vec.m in this directory means an end user can accidentally put a 'homonym' file somewhere in their path which causes a bug or gremlin. The solution would be to put all code other than sedumi.m and possibly the example problems in conversion into a subdirectory called private.

@mcg1969
Copy link
Contributor

mcg1969 commented Dec 23, 2014

I like this idea. I would welcome a pull request. What does everyone else think?

Do you know what version of MATLAB introduced the “private/“ functionality?

@shabbychef
Copy link
Author

It exists at least in r2007b (the version I am using).

@mcg1969
Copy link
Contributor

mcg1969 commented Dec 23, 2014

Very good. There's only one reason I can think of for not doing this: this is not considered the effort official repository. The folks at Lehigh University might not want to make the same change back on their local copy. I am not sure that a change this big merits a full fork.

@shabbychef
Copy link
Author

I suppose a user is free to unzip the archive in a directory called private, and move sedumi.m one directory up. I will test if that is sufficient.
BTW, are there any unit tests?

@mcg1969
Copy link
Contributor

mcg1969 commented Dec 23, 2014

No unit tests. It would certainly be a good idea.
Another option is to modify install_sedumi.m to move everything into a private/ subdirectory if possible. I'd let it fail softly if, for instance, the directory was read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants