bf_sim.c has two differing #defines of BOXFULL

[sqqqrly]

bf_sim.c:25 includes co.h
co.h:3 #define BOXFULL
bf_sim.c:40 #define BOXFULL 0x0008

The latter trumps.

BOXFULL is also defined and used by alc.c.

Could BOXFULL be removed from co.h?

[sqqqrly]

Added an #ifdef #undef to clear the warning in bf_sim.c

[unixtech493]

David,

Most of your programming questions are out of my expertise. I can answer general questions about how the system is supposed to function, or I can come and help you do actual testing, but I always left the specifics to Ravi. As far as I know he will still answer any of your questions by email. [email protected]

If you don’t get any response from him, let me know and I will reach out to him.

Jim

From: David Ohlemacher
Sent: Sunday, February 16, 2014 9:58 PM
To: sqqqrly/caps
Subject: [caps] bf_sim.c has two differing #defines of BOXFULL (#8)

bf_sim.c:25 includes co.h
co.h:3 #define BOXFULL
bf_sim.c:40 #define BOXFULL 0x0008

The latter trumps.

BOXFULL is also defined and used by alc.c.

Could BOXFULL be removed from co.h?

—
Reply to this email directly or view it on GitHub.

[sqqqrly]

I thought Ravi would be joining us on github but that is ok. 

The bugs in github are just things to address in the future plus some context. They are also areas that might cause issues and so should be tracked.

I thought I was done with recompiling and then found I had skipped over src/sys  which is huge.   I am working through it...up to the o's.    

There are no longer any warnings, 1000s have been fixed.   Warning should never be ignored and should not be allowed to remain in production code.  Even benign ones are bad as they tend to hide new ones that crop up.....seeing trees in a forest.

Including the required headers has made errors appear.  I am fixing as quick as I can type.   Everything is going into git.  

David

On Monday, February 17, 2014 1:22 PM, unixtech493 [email protected] wrote:

David,

Most of your programming questions are out of my expertise. I can answer general questions about how the system is supposed to function, or I can come and help you do actual testing, but I always left the specifics to Ravi. As far as I know he will still answer any of your questions by email. [email protected]

If you don’t get any response from him, let me know and I will reach out to him.

Jim

From: David Ohlemacher
Sent: Sunday, February 16, 2014 9:58 PM
To: sqqqrly/caps
Subject: [caps] bf_sim.c has two differing #defines of BOXFULL (#8)

bf_sim.c:25 includes co.h
co.h:3 #define BOXFULL
bf_sim.c:40 #define BOXFULL 0x0008

The latter trumps.

BOXFULL is also defined and used by alc.c.

Could BOXFULL be removed from co.h?

—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub.