Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire week rows are built during init #146

Open
royale1223 opened this issue Oct 10, 2014 · 2 comments
Open

Entire week rows are built during init #146

royale1223 opened this issue Oct 10, 2014 · 2 comments

Comments

@royale1223
Copy link

I could see that if we're initializing a CalendarPickerView to select a date in the span of 100 years, 5000+ week rows are built at the same time. This creates a noticeable lag of 10+ seconds in an LG Nexus 4. This could be optimized to build only the visible rows at init and build the other rows as user scrolls.

@edenman
Copy link
Collaborator

edenman commented Oct 10, 2014

This widget is definitely not intended for use with a 100 year window. We do all of the date math up front so that scrolling is as fast as it can be. That said, PRs welcome...if you're able to come up with a way to defer the date math and keep scrolling performance good, I'm all ears.

@JakeWharton
Copy link
Collaborator

As an alternative you might want to have a ViewPager with one page per-year. Scrolling through 100 years vertically isn't the best UX depending on how far you wanted to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants