Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Reason not defined. should be more specific #164

Open
jonlund opened this issue Jul 10, 2021 · 2 comments
Open

Generic Reason not defined. should be more specific #164

jonlund opened this issue Jul 10, 2021 · 2 comments

Comments

@jonlund
Copy link

jonlund commented Jul 10, 2021

Type Reason doesn't exist but is referenced several times. For example:

property reason on method GiftCardActivityAdjustDecrement should be GiftCardActivityAdjustDecrementReason not Reason.

property reason on method GiftCardActivityAdjustIncrement should be GiftCardActivityAdjustIncrementReason not Reason

same is true for GiftCardActivityBlock, GiftCardActivityClearBalance, GiftCardActivityDeactivate, and GiftCardActivityUnblock
@jonlund
Copy link
Author

jonlund commented Jul 10, 2021

also found the same thing for Type -> GiftCardType and Status -> GiftCardStatus

@jonlund
Copy link
Author

jonlund commented Jul 10, 2021

sorry, one more: Type->GiftCardActivityType on GiftCardActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonlund