Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two non-used source files #8

Open
micalevisk opened this issue Jan 31, 2022 · 1 comment
Open

Remove two non-used source files #8

micalevisk opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@micalevisk
Copy link

As of now, only the following files are exposed:

export * from './module';
export * from './storage';
export * from './drivers';
export * from './interfaces';

while the source has theses:

.
├── lib
│   ├── constants.ts
│   ├── driverManager.ts
│   ├── drivers
│   │   ├── index.ts
│   │   ├── local.ts
│   │   └── s3Storage.ts
│   ├── helpers
│   │   ├── extensions.ts
│   │   └── index.ts
│   ├── index.ts
│   ├── interfaces
│   │   ├── fileOptions.ts
│   │   ├── index.ts
│   │   ├── storageDriver.ts
│   │   └── storageOptions.ts
│   ├── module.ts
│   ├── provider.map.ts
│   ├── service.ts
│   ├── storage.module.ts   <<<<<<<<<<<<<
│   ├── storage.service.ts  <<<<<<<<<<<<<
│   └── storage.ts

To confirm that those two storage.* files aren't used anywhere:

image

image

@vinayak25
Copy link
Contributor

Thanks for reporting this, will be removed in next release.

@vinayak25 vinayak25 added the bug Something isn't working label Jan 31, 2022
@vinayak25 vinayak25 self-assigned this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants