Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No color dropper tool #22

Open
sraboy opened this issue Nov 15, 2015 · 2 comments
Open

No color dropper tool #22

sraboy opened this issue Nov 15, 2015 · 2 comments

Comments

@sraboy
Copy link
Owner

sraboy commented Nov 15, 2015

It's hard to identify colors in use without a color-picker/dropper tool. This is something that exists in the SkaaColorChooser (derived from ColorGrid) but hasn't been implemented yet.

@sraboy sraboy self-assigned this Nov 15, 2015
@sraboy sraboy added this to the Release 0.5 (beta) milestone Nov 15, 2015
@sraboy sraboy removed their assignment Dec 5, 2015
@sraboy
Copy link
Owner Author

sraboy commented Jan 1, 2016

Just notes to myself (though, @Olreich, if you're up to it, feel free to dig in).

See the SkaaColorChooser control in the SkaaEditorControls. It's derived from the ColorGrid in the Cyotek.Windows.Forms.ColorPicker project.

The problem is that the color picker, by default, allows selecting any color based on anything you hover over anywhere on the screen. It should be limited to the current color palette. Whether this could/should be done by simple disabling the tool once you move the mouse outside the window or just not recognizing other colors, I don't know.

@7k2
Copy link

7k2 commented Mar 20, 2016

I guess you could compute the nearest matching color in the palette. But, like you said, it probably makes more sense to restrict it to the (sprite) window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants