Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on non-optimized join does not pretty print conditions correctly #363

Open
smola opened this issue Apr 9, 2018 · 0 comments
Open
Labels

Comments

@smola
Copy link
Contributor

smola commented Apr 9, 2018

Expected Behavior

When I get the join optimization error (i.e. This Join could not be optimized. This might severely impact the performance...) I should be able to read the list of conditions that could not match.

Current Behavior

I get a default toString representation that is not that helpful.

18/04/09 09:35:30 ERROR GitOptimizer: * Reason:                                                                      *
18/04/09 09:35:30 ERROR GitOptimizer: * Obtained unsupported conditions: Set(org.apache.spark.sql.catalyst.expressio *
18/04/09 09:35:30 ERROR GitOptimizer: * ns.AttributeEquals@53a96fc) 

Possible Solution

Use a human-readable string representation.

Steps to Reproduce (for bugs)

  1. Execute a query with a non-optimizable join because of unsupported conditions. Example query at https://github.com/src-d/engine/issues/364
  2. Check logs.

Context

I'm exploring complex queries on engine. Better text representation of these errors might remove some guess work involved in identifying problems.

Your Environment

  • Version used: engine-jupyter 0.5.5 on Docker
  • Operating System and version: pipeline-staging cluster
@smola smola added the bug label Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant