Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #13

Open
carlosms opened this issue Sep 26, 2019 · 1 comment
Open

Add tests #13

carlosms opened this issue Sep 26, 2019 · 1 comment
Assignees
@kyrcha

Comments

@carlosms
Copy link
Contributor

carlosms commented Sep 26, 2019 •
edited
Loading

The code from #1 does not include any test.

Maybe we can use something like https://github.com/buger/goreplay.

Related issue: [private] https://github.com/src-d/infrastructure/issues/1130
@kyrcha kyrcha mentioned this issue Oct 1, 2019
Open
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 4, 2019
@kyrcha
Implements review comments, Adresses src-d#13
f5923a0 
Signed-off-by: Kyriakos Chatzidimitriou <[email protected]>
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 4, 2019
@kyrcha
Implements review comments, Adresses src-d#13
1e131d3 
Signed-off-by: Kyriakos Chatzidimitriou <[email protected]>
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 4, 2019
@kyrcha
Implements review comments, Adresses src-d#13
59b778f
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 4, 2019
@kyrcha
Implements review comments, Adresses src-d#13
a19fbb7 
Signed-off-by: Kyriakos Chatzidimitriou <[email protected]>
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 4, 2019
@kyrcha
Implements review comments, Adresses src-d#13
7ee9dec 
Signed-off-by: Kyriakos Chatzidimitriou <[email protected]>
kyrcha added a commit to kyrcha/metadata-retrieval that referenced this issue Oct 7, 2019
@kyrcha
Test additions, travis integration, addresses (but not closes) src-d#13
b1e7c6a 
Signed-off-by: Kyriakos Chatzidimitriou <[email protected]>
@kyrcha kyrcha mentioned this issue Oct 7, 2019
Merged
@kyrcha
Copy link
Contributor

kyrcha commented Oct 17, 2019 •
edited
Loading

Tasks:

  • Online tests
  • Offline tests (without errors)
  • Offline tests (with errors)

This was referenced Oct 24, 2019
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyrcha kyrcha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyrcha @carlosms