Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle clab topo "kinds" #48

Closed
carlmontanari opened this issue Oct 13, 2023 · 3 comments
Closed

feat: handle clab topo "kinds" #48

carlmontanari opened this issue Oct 13, 2023 · 3 comments

Comments

@carlmontanari
Copy link
Contributor

we dont, and we need to. so... title?

@hellt
Copy link
Member

hellt commented Oct 13, 2023

This would also mean supporting defaults for a full resolution tree
defaults -> kinds -> node

In the long run this is definitely should be leveraging clab functions to not duplicate a considerable amount of code.

@carlmontanari
Copy link
Contributor Author

copy

yep, I think from c9s perspective its just literally copying the stuff into the sub topology, so not really anything for c9s to do. I guess at the most complicated end we could parse the kinds and only put the relevant kind in the sub topo but for pass 1 I dont think thats even needed.

@carlmontanari
Copy link
Contributor Author

I believe this is sorted now as we include kinds/defaults from parent topo into sub topos, so ima close for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants