Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this code actually used? #4

Open
fidergo-stephane-gourichon opened this issue Jan 9, 2017 · 3 comments
Open

Is this code actually used? #4

fidergo-stephane-gourichon opened this issue Jan 9, 2017 · 3 comments

Comments

@fidergo-stephane-gourichon

Hello.

I've tried your code along with
https://github.com/sonyarouje
https://github.com/OzTK/DDPClient.NET
https://github.com/icereed/Stargazer.NET

This repo https://github.com/sroj/DDPClient.NET, especially branch feature-observable-api clearly has the more elegant design. This contrasts with others.

Also, is it normal that it doesn't even try to reply to Meteor-level pings? As a result, the server closes connection after a moment.

So, is it actually used or wholly unfinished?

There has been no commit nearly a year on this repo. Is the project dead? Have you switched to some alternative? Can you recommend anything?

Thank you for your attention.

@sroj
Copy link
Owner

sroj commented Jan 9, 2017

Hello. Unfortunately, I stopped working on this project after that last commit nearly a year ago, so the work was left unfinished and the project can be considered dead today.
I was doing this because we were considering using Xamarin and Rocket.Chat for a new app (hence the need for a .NET DDP Client), but then we just moved on to fully native development (and stopped using Rocket.Chat), so I didn't have time to keep working on this.

I can't recommend a good alternative right now. However, do take a look at the open PR that fixes several problems found in https://github.com/OzTK/DDPClient.NET, if you decide to keep working on top of this.

Thank you for your interest.

@fidergo-stephane-gourichon
Copy link
Author

Thank you Simon for your reply. I understand you won't be working again on this code soon (if at all in the future). Thank you also for the context. Our context is a C# desktop app talking to a server. A DDP client should get us on track with less code. Has to be Win7 compatible, so this rules out https://github.com/sgaluza/Meteor.DDP .

However, do take a look at the open PR that fixes several problems found in https://github.com/OzTK/DDPClient.NET, if you decide to keep working on top of this.

Thanks. I had seen it before. You fixed those issues in your develop didn't you?

Considering taking over

None of the 4 offsprings of sonyarouje's code seem very active. Besides, you code seems well architectured, with some relevant cleanup and code design change (e.g. thread safety). Also, I'm not very savvy in DDP but I like your choice of Rx.Net of which I have some experience. All this makes me consider taking over your code rather than moving to others.

Failing an alternative, fallback would be https://github.com/stubailo/meteor-rest or others on http://www.meteorpedia.com/read/REST_API . For this project we're not concerned about performance, so long poll is okay. We're mostly concerned about quick progress with few code.

Can you provide a quick gut feeling of the code on your repo, especially most recent code on develop? Something that would help me distinguish between "basic feature working or very near, code is sane, you can go and build upon it, it won't bite" vs "has some nasty hard-to-track, hard-to-fix bugs, don't go that way alone unless you have a lot of time" (which I haven't).

Your hint will help decision. Thanks a lot.

@fidergo-stephane-gourichon
Copy link
Author

Also, I'm wondering about WebSocket4Net reliability. Testing with a Meteor server running https://angular-meteor.com/tutorials/socially/angular2/bootstrap, any variant of DDPClient.Net failed, either immediately or as soon as I upgraded WebSocket4Net. So, I've spent a number of hours tracking down the issue, you might find interesting the following : When server handshake reply comes fragmented, failure to go past handshake. · Issue #76 · kerryjiang/WebSocket4Net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants