You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I honestly don't know. isRoom on a pub? But that's not really my main point. The logic of isRoom on go-ssb right now is not confirming if go-ssb itself is a room or not, it is forwarding a request on to a room. But the logic of ping on go-ssb doesn't forward the request on to a room, it just responds a ping from the pub. The semantics of the calls are very different. I'm really not familiar with MUXRPC but this seems confusing and not intuitive. So again, maybe we just need docs?
That kind of architectural question of how it should be is above my pay grade to answer. It does make some sense to me to have tunnel.ping ping through to the final endpoint rather than be returned by the intermediate tunnel broker. But the one concern I have is that the current behavior is, as far as I can tell, consistent with the behavior of the JavaScript ssb-tunnel. If the decision is made that that doesn't make sense, then it should probably be changed in both places so the Go and JS versions are consistent and compatible and the client doesn't have to think about whether it's talking to a Go-based pub/room or a JS-based pub/room and manage its expectations of the ping behavior accordingly.
Tracking resolution for #221 (comment)
The text was updated successfully, but these errors were encountered: