Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test getting excluded, reinvited, joining a group again #89

Closed
1 task
Powersource opened this issue Apr 11, 2023 · 4 comments · Fixed by #111
Closed
1 task

Test getting excluded, reinvited, joining a group again #89

Powersource opened this issue Apr 11, 2023 · 4 comments · Fixed by #111
Assignees
@Powersource
Labels
must Needed to complete grant milestone

Comments

@Powersource
Copy link
Collaborator

Powersource commented Apr 11, 2023 •
edited
Loading

Realized this might be a problem here #88 (comment)

todos:

  • test listInvites. should list the new invite
@Powersource Powersource added the must Needed to complete grant milestone label Apr 11, 2023
@Powersource Powersource mentioned this issue Apr 11, 2023
Merged
4 tasks
@Powersource
Copy link
Collaborator Author

@mixmix see discussion in the linked comment

@Powersource
Copy link
Collaborator Author

also related #91 (comment)

@Powersource Powersource mentioned this issue Apr 19, 2023
Merged
@Powersource
Copy link
Collaborator Author

Powersource commented Apr 25, 2023 •
edited
Loading

It's been proposed we skip this requirement (for now) but could either way be nice to test (maybe unmerged) to see just how much this breaks stuff.

If we decide to not do this, we should at least put a block in addMembers() against doing this. So we block it at the code, not protocol/message level. Could get tricky in the future with backwards compat though if we decide at some point to support it though 🤔 Maybe v3?

@Powersource Powersource self-assigned this May 3, 2023
@Powersource
Copy link
Collaborator Author

maybe easier to do this one first #76

@Powersource Powersource mentioned this issue May 9, 2023
Merged
@mixmix mixmix mentioned this issue Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Powersource Powersource

Labels
must Needed to complete grant milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test adding someone back into the group ssbc/ssb-tribes2
1 participant
@Powersource