Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR2 | Validation 3 | comment review - "onboard" #335

Open
MathesonSho opened this issue Dec 31, 2024 · 1 comment · May be fixed by #386
Open

GR2 | Validation 3 | comment review - "onboard" #335

MathesonSho opened this issue Dec 31, 2024 · 1 comment · May be fixed by #386
Assignees
Labels
Cleanup Clean the repository, remove redundant etc. Comment Update compliance messages Iteration #1 Before V2.0 go-live PriorityForAssignees -Next

Comments

@MathesonSho
Copy link
Contributor

Describe the bug
Requirement gathering information about onboarding to Access Review is now outdated. MS guidance does not have any details about onboarding as the service is readily available to clients. The initial comment when there are no role assignment automated access reviews is no longer applicable. We can remove the reference to needing to onboard to the service.

Azure CaC version
v2.1.4

Expected behavior
If there are no role assignment automated access reviews the comment should tell the user to create one in order to be compliant.

Screenshots
image

@MathesonSho MathesonSho added Comment Update compliance messages Cleanup Clean the repository, remove redundant etc. labels Dec 31, 2024
@MathesonSho
Copy link
Contributor Author

noAutomatedAccessReview: There are no automated access reviews configured for Microsoft Entra ID directory roles. Set up an annual access review for a highly privileged role.

noScheduledAccessReview: There are no recurring or current automated access reviews for Microsoft Entra ID directory roles. Ensure reviews are set to recur.

hasScheduledAccessReview: There is at least one scheduled automated access review for Microsoft Entra ID directory roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Clean the repository, remove redundant etc. Comment Update compliance messages Iteration #1 Before V2.0 go-live PriorityForAssignees -Next
Projects
None yet
3 participants