Merge pull request #191 from dhk2/develop

fix the duplicate controllers in floating mode, and a possible crashing bug
sschueller · Jun 28, 2020 · a7874e3 · a7874e3
2 parents f942e27 + 5da8d68
commit a7874e3
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/app/src/main/java/net/schueller/peertube/activity/VideoPlayActivity.java b/app/src/main/java/net/schueller/peertube/activity/VideoPlayActivity.java
@@ -353,10 +353,16 @@ public void enterPipMode() {
     }
     @Override
     public void onPictureInPictureModeChanged (boolean isInPictureInPictureMode, Configuration newConfig) {
+        FragmentManager fragmentManager = getSupportFragmentManager();
+        VideoPlayerFragment videoPlayerFragment = (VideoPlayerFragment) fragmentManager.findFragmentById(R.id.video_player_fragment);
+
         if (isInPictureInPictureMode) {
             Log.v(TAG,"switched to pip ");
+            videoPlayerFragment.useController(false);
         } else {
             Log.v(TAG,"switched to normal");
+            videoPlayerFragment.useController(true);
         }
     }
+
 }
diff --git a/app/src/main/java/net/schueller/peertube/fragment/VideoPlayerFragment.java b/app/src/main/java/net/schueller/peertube/fragment/VideoPlayerFragment.java
@@ -199,7 +199,11 @@ public void onFailure(@NonNull Call<Video> call, @NonNull Throwable t) {
             }
         });
     }
-
+    public void useController(boolean value){
+        if (mBound){
+            simpleExoPlayerView.setUseController(value);
+        }
+    }
     private void playVideo(Video video) {
 
         Context context = getContext();

diff --git a/app/src/main/java/net/schueller/peertube/service/VideoPlayerService.java b/app/src/main/java/net/schueller/peertube/service/VideoPlayerService.java
@@ -130,8 +130,12 @@ public void onDestroy() {
             playerNotificationManager.setPlayer(null);
         }
         //Was seeing an error when exiting the program about about not unregistering the receiver.
-        if (null!=myNoisyAudioStreamReceiver) {
-            this.unregisterReceiver(myNoisyAudioStreamReceiver);
+        try {
+            if (null!=myNoisyAudioStreamReceiver) {
+                this.unregisterReceiver(myNoisyAudioStreamReceiver);
+            }
+        } catch (Exception e) {
+            Log.e("VideoPlayerService", "attempted to unregister a nonregistered service");
         }
         if (player != null) {
             player.release();