Skip to content

Commit

Permalink
Merge pull request #38 from ssciwr/fixup-version-relax
Browse files Browse the repository at this point in the history
Fix up detection of version 8
  • Loading branch information
dokempf authored May 5, 2022
2 parents 9a82cd9 + db04685 commit 4301b09
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
testing:
name: Unit Testing (Python ${{ matrix.python }})
name: Unit Testing (Python ${{ matrix.python }}, ipywidgets${{ matrix.ipywidgets }})
runs-on: ubuntu-20.04
strategy:
matrix:
Expand All @@ -23,6 +23,9 @@ jobs:
- "3.8"
- "3.9"
- "3.10"
ipywidgets:
- "<8"
- "==8.0.0rc0"

steps:
- name: Checkout repository
Expand All @@ -35,6 +38,7 @@ jobs:

- name: Install package and development dependencies
run: |
python -m pip install "ipywidgets${{ matrix.ipywidgets }}"
python -m pip install .
python -m pip install -r requirements-dev.txt
Expand Down
2 changes: 1 addition & 1 deletion ipywidgets_jsonschema/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from ipywidgets_jsonschema.form import Form

__version__ = "0.8.0"
__version__ = "0.8.1"
2 changes: 1 addition & 1 deletion ipywidgets_jsonschema/form.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@


# We are providing some compatibility for ipywidgets v7 and v8
IS_VERSION_8 = version.parse(ipywidgets.__version__) >= version.parse("8")
IS_VERSION_8 = version.parse(ipywidgets.__version__).major == 8


class FormError(Exception):
Expand Down

0 comments on commit 4301b09

Please sign in to comment.