Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright frontend tests #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Dec 13, 2024

  • add CI job to run the tests
  • add instructions to frontend/README
  • add title to webpages
  • add data-testid to ResearchCodeInput component for locating it in testing
  • add initial tests of user registration with and without a research code
  • resolves Add frontend tests #121

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 33.87%. Comparing base (e594e1b) to head (1cebc46).

Files with missing lines Patch % Lines
frontend/playwright.config.ts 0.00% 39 Missing and 1 partial ⚠️
.../lib/components/DataInput/ResearchCodeInput.svelte 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   34.23%   33.87%   -0.36%     
==========================================
  Files         109      110       +1     
  Lines        3783     3823      +40     
  Branches       94       95       +1     
==========================================
  Hits         1295     1295              
- Misses       2409     2448      +39     
- Partials       79       80       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan force-pushed the fix_121_add_playwright_frontend_tests branch 2 times, most recently from 986238d to 6063050 Compare December 13, 2024 10:59
- add CI job to run the ui tests
- add instructions to frontend/README
- add title to webpages
- add data-testid to ResearchCodeInput component for locating it when testing
- add tests of user registration link with and without a research code
- resolves #121
@lkeegan lkeegan force-pushed the fix_121_add_playwright_frontend_tests branch from 6063050 to 1cebc46 Compare December 13, 2024 11:04
Copy link

sonarcloud bot commented Dec 13, 2024

@lkeegan lkeegan requested a review from MaHaWo December 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add frontend tests
2 participants