Drop net7.0 target #1468
Open
Drop net7.0 target #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET 7 is EOL since May. The only .NET 7 features we use are `ObjectDisposedException.ThrowIf` (moved to a throw helper) and some newer regex features. This feels a bit weird, but I suppose it is the expected course of action.
WojciechNagorski
requested changes
Aug 11, 2024
|
Sure |
|
Does it hurt us to keep supporting .NET 7.0? Do we want to be so agressive in removing support for TFMs that are EOL? |
|
It is obviously not a great hinderance atm, as there is not much net7.0-specific code. That's also a reason to drop it without ill effect. IMO it is not much more nuanced than: if Microsoft don't support it, then why should we? Anyway, let's do another release and re-evaluate for the one after. |
|
Also note that dropping net7.0 doesn't actually prevent net7.0 applications from using SSH.NET . They will just fall back to the |
# Conflicts: # src/Renci.SshNet/BaseClient.cs # src/Renci.SshNet/Common/ThrowHelper.cs # src/Renci.SshNet/SubsystemSession.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 7 is EOL since May. The only .NET 7 features we use are
ObjectDisposedException.ThrowIf(moved to a throw helper) and some newer regex features.This feels a bit weird, but I suppose it is the expected course of action.