Fix exception when reading duplicate sftp extensions #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviburg
reviewed
Nov 23, 2020
| @@ -251,7 +251,14 @@ protected string[] ReadNamesList() | |||
| { | |||
| var extensionName = ReadString(Ascii); | |||
| var extensionData = ReadString(Ascii); | |||
| result.Add(extensionName, extensionData); | |||
| if (result.ContainsKey(extensionName)) //if sftp extension is present multiple-times then keep the last one | |||
There was a problem hiding this comment.
It's difficult to judge what the right behavior is for duplicate extension value.
Do you have a specification reference for SFTP extension to support a decision one way or another?
Can there be an approach similar to HTTP's multiple value for same header, which combines the values to a string with a known separator?
Or update the dictionary to be <string, IEnumerable>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server return duplicated sftp extensions then we keep the last value instead of throwing an exception
Fix #726