Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation schemes for python #3

Open
sflis opened this issue Feb 18, 2020 · 2 comments
Open

Installation schemes for python #3

sflis opened this issue Feb 18, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sflis
Copy link
Contributor

sflis commented Feb 18, 2020

The problem now is that setup.py simply copies the extensions to the install location without changing the link path in library. Either we use patchelf while installing the python package (this assumes that the C++ libraries have already been installed and we can figure out the location of those) or installation of everything is handled by cmake (then it automatically sets the correct link path when copying the libraries).

Even if cmake is handling the install the python package setup should be handled by distutils and pip so that the package is correctly registered and we later can easily add consol-scripts as applications.

@sflis
Copy link
Contributor Author

sflis commented Feb 18, 2020

So this seems to be mostly fixed with a4eba84, however I let this issue stay as the final installation procedure has not yet been decided.

@sflis sflis added the enhancement New feature or request label Feb 20, 2020
@sflis
Copy link
Contributor Author

sflis commented Feb 29, 2020

With the changes made in #11, the current python installation with setup.py makes two copies of the extensions in the _ext folder. One of the original file and one of the symlink (which has the correct module name). This should be fixed somehow by excluding files which have .so or .dylib extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants